Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix building api-docs #1929

Merged
merged 1 commit into from
Dec 10, 2019
Merged

docs: fix building api-docs #1929

merged 1 commit into from
Dec 10, 2019

Conversation

straker
Copy link
Contributor

@straker straker commented Dec 4, 2019 •
edited by stephenmathieson
Loading

Closes issue: #1917

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner December 4, 2019 17:02
@stephenmathieson
Copy link
Member

Do you want me to make build_api_docs a required check?

@straker
Copy link
Contributor Author

straker commented Dec 10, 2019

@stephenmathieson Ya, if the docs can't be built we should probably fail the build

@straker straker merged commit e1ecd8e into develop Dec 10, 2019
@straker straker deleted the apiDocs branch December 10, 2019 20:30
straker added a commit that referenced this pull request Dec 11, 2019
@straker
docs: fix building api-docs (#1929)
5b829a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmathieson stephenmathieson stephenmathieson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straker @stephenmathieson