Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doT.js): prevent errors in older versions of Safari #1884

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Conversation

straker
Copy link
Contributor

@straker straker commented Nov 6, 2019

Fixes errors in older Safari from __magic__ global code.

Closes issue: #1764

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner November 6, 2019 20:50
@stephenmathieson
Copy link
Member

This should be a "fix" to ensure it shows up in the changelog. Maybe:

fix: Prevent "whatever exception" error in Safari

@straker straker changed the title chore: update doT version fix(doT.js): fixes errors in older versions of Safari Nov 7, 2019
@straker straker changed the title fix(doT.js): fixes errors in older versions of Safari fix(doT.js): prevent errors in older versions of Safari Nov 7, 2019
@straker straker merged commit b4dcab9 into develop Nov 7, 2019
@straker straker deleted the updatedoT branch November 7, 2019 18:22
straker added a commit that referenced this pull request Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants