Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rule): New aria-input-field-label rule #1610

Merged
merged 9 commits into from
Jun 6, 2019
Merged

feat(rule): New aria-input-field-label rule #1610

merged 9 commits into from
Jun 6, 2019

Conversation

jeeyyy
Copy link
Contributor

@jeeyyy jeeyyy commented Jun 5, 2019 •
edited by WilcoFiers
Loading

Note: This rule was authored off a branch from PR #1450, so ideally best to merge the #PR 1450 first.

Ensures elements with one of the below semantic roles has a label.

  • combobox
  • listbox
  • searchbox
  • slider
  • spinbutton
  • textbox

Closes issue:

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @WilcoFiers

@jeeyyy jeeyyy requested a review from a team as a code owner June 5, 2019 14:45
@CLAassistant
Copy link

CLAassistant commented Jun 5, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jeeyyy jeeyyy mentioned this pull request Jun 5, 2019
Merged
4 tasks
WilcoFiers
WilcoFiers previously requested changes Jun 5, 2019
View reviewed changes
lib/rules/aria-input-field-label.json Outdated
"aria-label",
"aria-labelledby",
"non-empty-title",
"has-visible-text"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't belong here. These elements don't have name from content. Because this check is a little off, I don't actually think you have to change any of the test cases.

WilcoFiers
WilcoFiers previously requested changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial

test/integration/rules/aria-input-field-label/aria-input-field-label.html Outdated Show resolved Hide resolved
test/integration/rules/aria-input-field-label/aria-input-field-label.html Outdated Show resolved Hide resolved
test/integration/rules/aria-input-field-label/aria-input-field-label.html Outdated Show resolved Hide resolved
@jeeyyy jeeyyy requested a review from WilcoFiers June 5, 2019 18:30
@WilcoFiers WilcoFiers changed the title feat(rule): aria-input-field-label feat(rule): New aria-input-field-label rule Jun 6, 2019
@WilcoFiers WilcoFiers merged commit 73d5273 into develop Jun 6, 2019
@WilcoFiers WilcoFiers deleted the rule-aria-input-field-label branch June 6, 2019 11:26
@jeankaplansky jeankaplansky added the docs Documentation changes label Jun 11, 2019
@jeankaplansky jeankaplansky self-assigned this Jun 11, 2019
@dylanb dylanb mentioned this pull request Jun 16, 2019
Closed
This was referenced Jun 17, 2019
Closed
Closed
Closed
@jeeyyy jeeyyy mentioned this pull request Jun 26, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees

@jeankaplansky jeankaplansky

Labels
docs Documentation changes wai-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeeyyy @CLAassistant @WilcoFiers @jeankaplansky