-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(role-img-alt): Split rule for role=img with no accessible name #1586
Conversation
d984b70
to
802260e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor points.
lib/rules/role-img-alt.json
Outdated
], | ||
"metadata": { | ||
"description": "Ensures [role='img'] elements have alternate text", | ||
"help": "Images must have alternate text" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change this to [role='img'] elements have an alternative text
, to distinguish it from other "image" rules.
@@ -0,0 +1,13 @@ | |||
<div id="match">Bananas</div> | |||
<div id="hidden-match" style="display:none">Banana bombs</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to put role="img"
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that's purely for testing aria-labelledby
, it's a pattern used in other alt
tests.
802260e
to
fdfd886
Compare
This also removes
[role='img']
selector fromimage-alt
rule.issue: #1192
Reviewer checks
Required fields, to be filled out by PR reviewer(s)