test: fix test for Safari #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scurker
reviewed
May 9, 2019
straker
changed the title
WilcoFiers
previously requested changes
May 10, 2019
| // returns null as isSame is false. we can fix this by adding in the | ||
| // missing label to the boundingStack before checking for isSame | ||
| // @see https://bugs.webkit.org/show_bug.cgi?id=197743 | ||
| includeMissingElements(boundingStack, elm); |
There was a problem hiding this comment.
This is already happening in getBackgroundStack. I don't quite understand why you'd call this twice.
There was a problem hiding this comment.
So the includeMissingElements call in getBackgroundStack is not called since filteredRectStack returns null because it's missing the label. I tried removing the includeMissingElements in getBackgroundStack but that failed a lot of tests.
stephenmathieson
previously requested changes
May 14, 2019
stephenmathieson
approved these changes
May 16, 2019
stephenmathieson
changed the title
stephenmathieson
added a commit
that referenced
this pull request
May 16, 2019
* develop: test: fix test for Safari (#1557) test: fix flakey test (#1573) test: fix tests failing in IE11 (#1570) test: only run IE11 tests in appveyor (#1571) chore: run prettier and format (#1568) test: disable es6 syntax usage within tests directory (#1569) feat(rule): add additional elements to check for incomplete with required children (#1547)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two Safari browser bugs that I had to work around, and one difference in floating point precision, but I got the tests working locally for Safari. Unfortunately I couldn't get it to work in CircleCI, so we'll have to come back to that in a later pr.
Closes: #1385
Reviewer checks
Required fields, to be filled out by PR reviewer(s)