Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Avoid publishing unnecessary files to NPM #1408

Merged
merged 5 commits into from
Mar 6, 2019
Merged

chore: Avoid publishing unnecessary files to NPM #1408

merged 5 commits into from
Mar 6, 2019

Conversation

WilcoFiers
Copy link
Contributor

@WilcoFiers WilcoFiers commented Mar 5, 2019 •
edited by jeeyyy
Loading

Speaks for itself.

Closes issue: none

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @JKODU

@WilcoFiers WilcoFiers requested a review from a team as a code owner March 5, 2019 11:52
@stephenmathieson
Copy link
Member

What is this fixing?

@WilcoFiers
Copy link
Contributor Author

@stephenmathieson those files are only used for development. This is just removing clutter.

@stephenmathieson
Copy link
Member

Right. I'd call it a "chore" then, since it doesn't fix a bug.

@WilcoFiers WilcoFiers changed the title fix: Avoid publishing unnecessary files to NPM chore: Avoid publishing unnecessary files to NPM Mar 6, 2019
@WilcoFiers
Copy link
Contributor Author

@stephenmathieson updated.

@scurker
Copy link
Member

scurker commented Mar 6, 2019

Just a thought: Would it be better to use a whitelist instead of a blacklist?

@stephenmathieson
Copy link
Member

@scurker yes, probably, but the path of least resistance is just adding these few entries to the existing .npmignore.

@stephenmathieson stephenmathieson merged commit 11aa039 into develop Mar 6, 2019
@stephenmathieson stephenmathieson deleted the npmignore branch March 6, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmathieson stephenmathieson stephenmathieson approved these changes

@jeeyyy jeeyyy jeeyyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WilcoFiers @stephenmathieson @scurker @jeeyyy