Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add combobox and radio required properties #1093

Merged
merged 1 commit into from
Aug 23, 2018
Merged

fix: Add combobox and radio required properties #1093

merged 1 commit into from
Aug 23, 2018

Conversation

WilcoFiers
Copy link
Contributor

@WilcoFiers WilcoFiers commented Aug 23, 2018 •
edited by jeeyyy
Loading

Add new required properties:

  • combobox required aria-expanded
  • radio required aria-checked

Closes #969

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Has documentation updated, a DU ticket, or requires no documentation change
  • Includes new tests, or was unnecessary
  • Code is reviewed for security by: @JKODU

@WilcoFiers WilcoFiers requested a review from a team as a code owner August 23, 2018 08:49
jeeyyy
jeeyyy approved these changes Aug 23, 2018
View reviewed changes
Copy link
Contributor

@jeeyyy jeeyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dylanb dylanb merged commit 01536dd into develop Aug 23, 2018
@WilcoFiers WilcoFiers deleted the aria-required branch August 27, 2018 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanb dylanb dylanb approved these changes

@jeeyyy jeeyyy jeeyyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WilcoFiers @dylanb @jeeyyy