Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(skip-link): work with absolute and relative paths #2875

Merged
merged 15 commits into from
Jan 20, 2022
Merged

fix(skip-link): work with absolute and relative paths #2875

merged 15 commits into from
Jan 20, 2022

Conversation

straker
Copy link
Contributor

@straker straker commented Apr 15, 2021

Closes issue: #2791

@straker straker requested a review from a team as a code owner April 15, 2021 17:16
WilcoFiers
WilcoFiers previously requested changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small things.

lib/commons/dom/is-skip-link.js Outdated Show resolved Hide resolved
lib/commons/dom/is-skip-link.js Outdated Show resolved Hide resolved
lib/commons/dom/is-skip-link.js Outdated Show resolved Hide resolved
@straker straker changed the title fix(skip-link): work with absoulte and relative paths [WIP] fix(skip-link): work with absoulte and relative paths Apr 30, 2021
Boone6969
Boone6969 previously approved these changes Aug 14, 2021
View reviewed changes
@CLAassistant
Copy link

CLAassistant commented Aug 27, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@WilcoFiers WilcoFiers changed the title [WIP] fix(skip-link): work with absoulte and relative paths fix(skip-link): work with absoulte and relative paths Dec 14, 2021
@straker straker changed the title fix(skip-link): work with absoulte and relative paths [WIP] fix(skip-link): work with absoulte and relative paths Jan 6, 2022
@straker straker changed the title [WIP] fix(skip-link): work with absoulte and relative paths fix(skip-link): work with absolute and relative paths Jan 17, 2022
WilcoFiers
WilcoFiers reviewed Jan 18, 2022
View reviewed changes
test/node/jsdom.js Outdated Show resolved Hide resolved
WilcoFiers
WilcoFiers previously requested changes Jan 19, 2022
View reviewed changes
lib/commons/dom/is-current-page-link.js Outdated Show resolved Hide resolved
@straker straker merged commit ee49d3e into develop Jan 20, 2022
@straker straker deleted the absolute-skip-link branch January 20, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

@Boone6969 Boone6969 Boone6969 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@straker @CLAassistant @WilcoFiers @Boone6969