Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule: SC2-5-3-label-content-name-mismatch (PR #1159) #1149

Closed
jeeyyy opened this issue Sep 18, 2018 · 1 comment
Closed

Rule: SC2-5-3-label-content-name-mismatch (PR #1159) #1149

jeeyyy opened this issue Sep 18, 2018 · 1 comment
Assignees
@jeeyyy
Labels
rules Issue or false result from an axe-core rule wai-tools wcag 2.1

Comments

@jeeyyy
Copy link
Contributor

jeeyyy commented Sep 18, 2018 •
edited
Loading

Spec: https://act-rules.github.io/rules/2ee8b8
@jeeyyy jeeyyy self-assigned this Sep 18, 2018
@jeeyyy jeeyyy added rules Issue or false result from an axe-core rule wai-tools wcag 2.1 labels Sep 18, 2018
@jeeyyy jeeyyy mentioned this issue Sep 26, 2018
Closed
4 tasks
@jeeyyy jeeyyy changed the title New Rule: SC2-5-3-label-content-name-mismatch Rule: SC2-5-3-label-content-name-mismatch (PR #1159) Sep 27, 2018
@jeeyyy jeeyyy mentioned this issue Jan 28, 2019
Merged
4 tasks
WilcoFiers pushed a commit that referenced this issue Feb 21, 2019
@jeeyyy @WilcoFiers
feat(rule): Label and Name from Content mismatch WCAG21 (Issue #1149) (…
a4255da 
…#1335)

* chore(WIP): rewrite accessibleText

* chore: More refactoring for accname

* chore(WIP): More improvements to accessibleName

* feat: Reimplement accessible name computation

* chore: All accessible name tests passing

* chore(accName): All tests passing

* chore: Add tests

* chore: Test form-control-value

* chore: Refactor and add docs to accessible-text

* chore: Add tests for namedFromContents

* chore: Refactor subtreeText method

* chore: Refactor native accessible text methods

* chore: Coverage for text.labelText

* fix: update to axe.commons.matches usage

* test: fix nativeTextboxValue tests

* test: fix failing tests

* fix: compute includeHidden as a part of accessibleName fn

* fix: do not mutate context in accessibleText

* feat: rule for label and name from content mismatch

* fix: refactor based on review and add unicode computation

* refactor: update based on code review

* test: update test

* chore: fix linting errors

* refactor: updates based on code review

* refactor: unicode and punctuation methods

* test: update tests
@jeeyyy jeeyyy closed this as completed Feb 26, 2019
@straker straker mentioned this issue Jun 18, 2019
Closed
@dylanb
Copy link
Contributor

dylanb commented Jun 19, 2019

@JKODU the link referenced in this issue is broken, can you find the new link and update this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeeyyy jeeyyy

Labels
rules Issue or false result from an axe-core rule wai-tools wcag 2.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dylanb @jeeyyy