feat(duplicate-id-aria): set to review on fail and tag as wcag412 (#4075

)
dequelabs · Jul 3, 2023 · 9f1a3e3 · 9f1a3e3
1 parent 55000d0
commit 9f1a3e3
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 7 deletions.
diff --git a/doc/rule-descriptions.md b/doc/rule-descriptions.md
@@ -37,7 +37,7 @@
 | [definition-list](https://dequeuniversity.com/rules/axe/4.7/definition-list?application=RuleDescription)                         | Ensures &lt;dl&gt; elements are structured correctly                                                                                                  | Serious                  | cat.structure, wcag2a, wcag131, EN-301-549, EN-9.1.3.1                                                                             | failure                    |                                                                                                                                                                                                                                                                    |
 | [dlitem](https://dequeuniversity.com/rules/axe/4.7/dlitem?application=RuleDescription)                                           | Ensures &lt;dt&gt; and &lt;dd&gt; elements are contained by a &lt;dl&gt;                                                                              | Serious                  | cat.structure, wcag2a, wcag131, EN-301-549, EN-9.1.3.1                                                                             | failure                    |                                                                                                                                                                                                                                                                    |
 | [document-title](https://dequeuniversity.com/rules/axe/4.7/document-title?application=RuleDescription)                           | Ensures each HTML document contains a non-empty &lt;title&gt; element                                                                                 | Serious                  | cat.text-alternatives, wcag2a, wcag242, TTv5, TT12.a, EN-301-549, EN-9.2.4.2, ACT                                                  | failure                    | [2779a5](https://act-rules.github.io/rules/2779a5)                                                                                                                                                                                                                 |
-| [duplicate-id-aria](https://dequeuniversity.com/rules/axe/4.7/duplicate-id-aria?application=RuleDescription)                     | Ensures every id attribute value used in ARIA and in labels is unique                                                                                 | Critical                 | cat.parsing, wcag2a, wcag411, EN-301-549, EN-9.4.1.1                                                                               | failure                    | [3ea0c8](https://act-rules.github.io/rules/3ea0c8)                                                                                                                                                                                                                 |
+| [duplicate-id-aria](https://dequeuniversity.com/rules/axe/4.7/duplicate-id-aria?application=RuleDescription)                     | Ensures every id attribute value used in ARIA and in labels is unique                                                                                 | Critical                 | cat.parsing, wcag2a, wcag412, EN-301-549, EN-9.4.1.2                                                                               | needs&nbsp;review          | [3ea0c8](https://act-rules.github.io/rules/3ea0c8)                                                                                                                                                                                                                 |
 | [form-field-multiple-labels](https://dequeuniversity.com/rules/axe/4.7/form-field-multiple-labels?application=RuleDescription)   | Ensures form field does not have multiple label elements                                                                                              | Moderate                 | cat.forms, wcag2a, wcag332, TTv5, TT5.c, EN-301-549, EN-9.3.3.2                                                                    | needs&nbsp;review          |                                                                                                                                                                                                                                                                    |
 | [frame-focusable-content](https://dequeuniversity.com/rules/axe/4.7/frame-focusable-content?application=RuleDescription)         | Ensures &lt;frame&gt; and &lt;iframe&gt; elements with focusable content do not have tabindex=-1                                                      | Serious                  | cat.keyboard, wcag2a, wcag211, TTv5, TT4.a, EN-301-549, EN-9.2.1.1                                                                 | failure, needs&nbsp;review | [akn7bn](https://act-rules.github.io/rules/akn7bn)                                                                                                                                                                                                                 |
 | [frame-title-unique](https://dequeuniversity.com/rules/axe/4.7/frame-title-unique?application=RuleDescription)                   | Ensures &lt;iframe&gt; and &lt;frame&gt; elements contain a unique title attribute                                                                    | Serious                  | cat.text-alternatives, wcag2a, wcag412, TTv5, TT12.d, EN-301-549, EN-9.4.1.2                                                       | needs&nbsp;review          | [4b1c6c](https://act-rules.github.io/rules/4b1c6c)                                                                                                                                                                                                                 |

diff --git a/lib/rules/duplicate-id-aria.json b/lib/rules/duplicate-id-aria.json
@@ -3,7 +3,8 @@
   "selector": "[id]",
   "matches": "duplicate-id-aria-matches",
   "excludeHidden": false,
-  "tags": ["cat.parsing", "wcag2a", "wcag411", "EN-301-549", "EN-9.4.1.1"],
+  "tags": ["cat.parsing", "wcag2a", "wcag412", "EN-301-549", "EN-9.4.1.2"],
+  "reviewOnFail": true,
   "actIds": ["3ea0c8"],
   "metadata": {
     "description": "Ensures every id attribute value used in ARIA and in labels is unique",

diff --git a/test/integration/rules/duplicate-id-aria/duplicate-id-aria.html b/test/integration/rules/duplicate-id-aria/duplicate-id-aria.html
@@ -8,11 +8,11 @@
 <select id="ignore4"></select>
 <div tabindex="0" id="ignore5"></div>
 
-<span id="fail1" class="fail1"></span>
-<button id="fail1"></button>
+<span id="incomplete1" class="incomplete1"></span>
+<button id="incomplete1"></button>
 <span id="pass1"></span>
 <button id="pass2"></button>
-<div aria-labelledby="fail1 pass1 pass2"></div>
+<div aria-labelledby="incomplete1 pass1 pass2"></div>
 
 <input id="ignore6" type="hidden" />
 <button id="ignore7" disabled></button>

diff --git a/test/integration/rules/duplicate-id-aria/duplicate-id-aria.json b/test/integration/rules/duplicate-id-aria/duplicate-id-aria.json
@@ -1,6 +1,7 @@
 {
   "description": "duplicate-id-aria test",
   "rule": "duplicate-id-aria",
-  "violations": [[".fail1"]],
+  "violations": [],
+  "incomplete": [[".incomplete1"]],
   "passes": [["#pass1"], ["#pass2"]]
 }
diff --git a/test/integration/rules/runner.js b/test/integration/rules/runner.js
@@ -95,7 +95,11 @@
               // check that all nodes are removed
               assert.equal(JSON.stringify(targets), '[]');
             } else {
-              assert(false, 'there are no ' + collection);
+              assert.lengthOf(
+                test[collection],
+                0,
+                'there are no ' + collection
+              );
             }
           });
         });