feat: add v8::Isolate::snapshot_creator_from_existing_snapshot API #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
littledivy
previously requested changes
May 28, 2022
We'll address that, once we got working end-to-end prototype in |
littledivy
reviewed
Jun 7, 2022
piscisaureus
force-pushed
the
snapshotcreator_existing_blob
branch
from
ba12696
to
66d427e
Compare
piscisaureus
reviewed
Oct 4, 2022
littledivy
reviewed
Oct 5, 2022
| /// is no way to provide a global object template since we do not create | ||
| /// a new global object from template, but we can reuse a global object. | ||
| pub fn from_snapshot<'s>( | ||
| scope: &mut HandleScope<'s, ()>, |
There was a problem hiding this comment.
Do we need the scope here? Can this just take an &mut Isolate?
There was a problem hiding this comment.
In most cases you need to use scope immediately after calling this function, I think it's not worth the complexity.
bartlomieju
changed the title
existing_blob to SnapshotCreator constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds "v8::Isolate::snapshot_creator_from_existing_snapshot" API,
that allows to create a new snapshot from already existing snapshot.
Following APIs were added as well: