Upgrade V8 to 8.6.337 #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piscisaureus
added a commit
to piscisaureus/safe_v8
that referenced
this pull request
Aug 5, 2020
piscisaureus
force-pushed
the
upgrade_v8
branch
from
e525c2d
to
4eb3a30
Compare
piscisaureus
added a commit
to piscisaureus/safe_v8
that referenced
this pull request
Aug 5, 2020
piscisaureus
added a commit
to piscisaureus/safe_v8
that referenced
this pull request
Aug 5, 2020
piscisaureus
added a commit
to piscisaureus/safe_v8
that referenced
this pull request
Aug 5, 2020
piscisaureus
force-pushed
the
upgrade_v8
branch
from
280a376
to
6a2e9bf
Compare
piscisaureus
added a commit
to piscisaureus/safe_v8
that referenced
this pull request
Aug 5, 2020
piscisaureus
force-pushed
the
upgrade_v8
branch
from
6a2e9bf
to
1d0c1ac
Compare
piscisaureus
added a commit
to piscisaureus/safe_v8
that referenced
this pull request
Aug 5, 2020
After upgrading to V8 8.6.337, with a 20 MB heap limit the near-heap-limit callback never gets called before V8 runs out of memory. However 20 MB is also unrealistically low, so this patch increases the heap limit to 50 MB.
piscisaureus
added a commit
to piscisaureus/safe_v8
that referenced
this pull request
Aug 5, 2020
After upgrading to V8 8.6.337, with a 20 MB heap limit, the near-heap-limit callback never gets called before V8 runs out of memory. It turns out that the memory allocation pattern that this test generates creates so little actual garbage that 'scavenge' type garbage collections make memory usage go up rather than down. Because of this, V8 runs out of memory in the middle of a garbage collection cycle, after it has already decided that there's no need to run the near-heap-limit callback. The issue is fixed by making sure that some actual garbage is produced alongside with the retained objects that will eventually fill up the heap.
piscisaureus
force-pushed
the
upgrade_v8
branch
from
dd6be6c
to
61b91bb
Compare
piscisaureus
added a commit
to piscisaureus/safe_v8
that referenced
this pull request
Aug 6, 2020
After upgrading to V8 8.6.337, with a 20 MB heap limit, the near-heap-limit callback never gets called before V8 runs out of memory. It turns out that this test exhibits memory allocation behavior which produces so little actual garbage that 'scavenge' type garbage collections make memory usage go up rather than down. Because of this, V8 runs out of memory in the middle of a garbage collection cycle, after it has already decided that there's no need to run the near-heap-limit callback. The issue is fixed by making sure that some actual garbage is produced alongside with the retained objects that will eventually fill up the heap.
piscisaureus
force-pushed
the
upgrade_v8
branch
from
61b91bb
to
6344976
Compare
piscisaureus
added a commit
to piscisaureus/safe_v8
that referenced
this pull request
Aug 6, 2020
After upgrading to V8 8.6.337, with a 20 MB heap limit, the near-heap-limit callback never gets called before V8 runs out of memory. It turns out that this test exhibits memory allocation behavior which produces so little actual garbage that 'scavenge' type garbage collections make memory usage go up rather than down. Because of this, V8 runs out of memory in the middle of a garbage collection cycle, after it has already decided that there's no need to run the near-heap-limit callback. The issue is fixed by making sure that some actual garbage is produced alongside with the retained objects that will eventually fill up the heap.
piscisaureus
force-pushed
the
upgrade_v8
branch
from
f168c3f
to
6145d0c
Compare
After upgrading to V8 8.6.337, with a 20 MB heap limit, the near-heap-limit callback never gets called before V8 runs out of memory. It turns out that this test exhibits memory allocation behavior which produces so little actual garbage that 'scavenge' type garbage collections make memory usage go up rather than down. Because of this, V8 runs out of memory in the middle of a garbage collection cycle, after it has already decided that there's no need to run the near-heap-limit callback. The issue is fixed by making sure that some actual garbage is produced alongside with the retained objects that will eventually fill up the heap.
piscisaureus
force-pushed
the
upgrade_v8
branch
from
0c65170
to
954163a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.