Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize FunctionCallbackInfo and PropertyCallbackInfo methods #1104

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

piscisaureus
Copy link
Member

Before:

Running function_overhead ...
  15.1 ns per run 66.2 million ops/sec → new_
  15.2 ns per run 65.7 million ops/sec → new_raw
  11.2 ns per run 89.7 million ops/sec → new_set_uint32
  6.8 ns per run 147.1 million ops/sec → new_raw_set_uint32
  2.7 ns per run 367.6 million ops/sec → new_fast
Running primitives ...
  11.7 ns per run 85.3 million ops/sec → undefined_from_scope
  7.5 ns per run 133.2 million ops/sec → undefined_from_isolate

After:

Running function_overhead ...
  14.6 ns per run 68.7 million ops/sec → new_
  14.7 ns per run 67.9 million ops/sec → new_raw
  10.9 ns per run 91.7 million ops/sec → new_set_uint32
  6.8 ns per run 147.9 million ops/sec → new_raw_set_uint32
  2.7 ns per run 367.6 million ops/sec → new_fast
Running primitives ...
  11.2 ns per run 89.5 million ops/sec → undefined_from_scope
  6.3 ns per run 158.7 million ops/sec → undefined_from_isolate

@piscisaureus piscisaureus force-pushed the optimize_callback_info branch 3 times, most recently from 2f6c1e4 to 8c6bfae Compare October 18, 2022 00:19
@piscisaureus piscisaureus merged commit d85f785 into denoland:main Oct 19, 2022
@piscisaureus piscisaureus deleted the optimize_callback_info branch October 19, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants