Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Update integration tests to clear all possible ivy caches + minor update to S3LogStoreUtilIntegrationTest #3258

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

allisonport-db
Copy link
Collaborator

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (INFRA)

Description

During integration testing and QA for the 4.0 preview release we noticed clearing the ~/.ivy2/ caches was not sufficient. This PR updates any scripts that clear artifacts to check for any subfolders that start with ".ivy" and clear any artifacts from there.

Also removes the conf setting ProfileCredentialsProvider as the credential provider for S3LogStoreUtilIntegrationTest. The default credential chain provider should include ProfileCredentialsProvider anyways, and removing it allows us to provide credentials in any of the other ways supported in the chain provider.

How was this patch tested?

Ran the S3LogStoreUtilIntegrationTest as well as ran run-integration-tests.py locally to check it clears the right caches.

Does this PR introduce any user-facing changes?

No.

Copy link
Collaborator

@scottsand-db scottsand-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please update the PR description to give an explicit example of why looking for .ivy2 was insufficient (because it may be .ivy2.5.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants