Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi arch Docker image builds #1134

Closed
wants to merge 1 commit into from
Closed

Multi arch Docker image builds #1134

wants to merge 1 commit into from

Conversation

daanh432
Copy link
Contributor

@daanh432 daanh432 commented Sep 9, 2023

This pull requests switches to parallel building of the regular and alpine image building. Both of which will be built for both AMD64 (same as current) and ARM64 (new addition). See on Docker Hub

Using EKS or AKS with ARM based CPUs like Graviton these multi arch Docker images are wonderful to use.

All pipelines were also using node 18 except for the Dockerfile. I think it would be better to use the same node version for all artifacts.

Any existing Docker setup will not break. Everything is still mapped to /usr/local/deepstream.

Can be validated using the test image I have published on Docker Hub.

docker create -t -p 6020:6020 -p 6021:6021 \
  --name deepstream.io \
  -v $(pwd)/conf:/usr/local/deepstream/conf \
  -v $(pwd)/var:/usr/local/deepstream/var \
  daanh432/deepstream.io:7.0.8

@daanh432
Copy link
Contributor Author

Considering this project is unmaintained the pull request of this can be considered as irrelevant.

@daanh432 daanh432 closed this Sep 10, 2023
@jaime-ez
Copy link
Collaborator

Hi! It's not unmaintained, I'm just a slow maintainer!

I'm going to reopen the pull and I'll try to look into it soon, thanks

@jaime-ez jaime-ez reopened this Sep 14, 2023
@hugojosefson
Copy link
Contributor

If I understand correctly, this can now be considered merged too! 🎉
@daanh432's docker commit was included in my (now merged) PR #1135, because that was created on top of this PR.

@jaime-ez jaime-ez closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants