Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EEqn.H & YEqn.H for dfLowMachFoam and dfSprayFoam #247

Merged
merged 5 commits into from
Apr 23, 2023

Conversation

xiao312
Copy link
Collaborator

@xiao312 xiao312 commented Apr 19, 2023

No description provided.

@zhixchen zhixchen self-requested a review April 20, 2023 05:22
Copy link
Collaborator

@zhixchen zhixchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still redundancy in the code. Please revise further.

@zhixchen
Copy link
Collaborator

There is still redundancy in the code. Please revise further.

For example:

fvScalarMatrix EEqn
(
fvm::ddt(rho, he) + mvConvection->fvmDiv(phi, he)
+ fvc::ddt(rho, K) + fvc::div(phi, K)
- dpdt
turbName == "laminar"
?
(
+ diffAlphaD
- fvc::div(hDiffCorrFlux)
)
==
fvm::laplacian(turbulence->alphaEff(), he)
);

@zhixchen zhixchen merged commit 18d3c48 into deepmodeling:master Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants