Added support for head() and tail() for blink tables #4136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malhotrashivam
added
feature request
lbooker42
reviewed
Jul 6, 2023
engine/table/src/main/java/io/deephaven/engine/table/impl/BlinkTableTools.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/BlinkTableTools.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/SliceLikeOperation.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/BlinkTableTools.java
Outdated
Show resolved
Hide resolved
malhotrashivam
commented
Jul 7, 2023
engine/table/src/main/java/io/deephaven/engine/table/impl/SliceLikeOperation.java
Outdated
Show resolved
Hide resolved
lbooker42
reviewed
Jul 7, 2023
engine/table/src/main/java/io/deephaven/engine/table/impl/BlinkTableTools.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/SliceLikeOperation.java
Outdated
Show resolved
Hide resolved
malhotrashivam
commented
Jul 7, 2023
engine/table/src/test/java/io/deephaven/engine/table/impl/BlinkTableAggregationTest.java
Show resolved
Hide resolved
malhotrashivam
changed the title
rcaudy
reviewed
Jul 7, 2023
engine/table/src/main/java/io/deephaven/engine/table/impl/QueryTable.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/SliceLikeOperation.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/SliceLikeOperation.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Jul 10, 2023
engine/table/src/main/java/io/deephaven/engine/table/impl/BlinkTableTools.java
Outdated
Show resolved
Hide resolved
rcaudy
reviewed
Jul 10, 2023
engine/table/src/main/java/io/deephaven/engine/table/impl/BlinkTableTools.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/BlinkTableTools.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/BlinkTableTools.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/BlinkTableTools.java
Outdated
Show resolved
Hide resolved
rcaudy
approved these changes
Jul 11, 2023
|
Labels indicate documentation is required. Issues for documentation have been opened: How-to: https://github.com/deephaven/deephaven.io/issues/2891 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature request, closes #2411
Change description: Before this change, head/tail operations on blink table would return the head/tail of the rows added to the blink table in the latest update cycle. After this change, head/tail would act the same as they would on an append-only (full history) table derived from the stream. For example, head(10) on a blink table would store the first 10 rows received by the blink table after the operation and then won't change. Similarly, tail(10) would store the latest 10 rows received by the blink table.
Also, after this change, headPct(), taillPct() and slice() will not be supported for blink tables and will return an error.
Documentation change: We need to provide the above description in the documentation pages of blink tables and these operations. These are some places I could find: Blink table, head Python, head Java, tail Python, tail Java