Re-implement shadow's "component" method to correctly #4129
Conversation
Does not address deephaven#4122, which would require changing shadow to use components correctly. Fixes deephaven#4119
niloc132
added
NoDocumentationNeeded
ReleaseNotesNeeded
|
This is not an ideal fix, but it does the job. I wasn't able to get the shadow plugin to be delayed in its changes of the default pom instance so that the GenerateMavenPom task is able to write it correctly, but instead just reimplements the logic to more closely match what we expect. A "better" fix would delay our call to project.shadow.component() until after gradle has processed the artifactId changes to all dependency projects, propagating them into their own poms, so that they can be read. A "good" fix would be to provide a variant or a component just for the shadow. It appears that the shadow plugin attempts to do this, but doesn't really commit to it (giving us #4122). Note that we also cannot update to shadow 8.1.1 at this time, as it requires gradle 8. |
|
Filed #4132 for follow-up. |
buildSrc/src/main/groovy/io.deephaven.java-shadow-publishing-conventions.gradle
Outdated
Show resolved
Hide resolved
Based on my read of the specific sources involved with this bug, this is unlikely to help. |
Does not address #4122, which would require changing shadow to use components correctly.
Fixes #4119