GRPC: Allow string duration parameters for UpdateBy ema/rolling windows #4042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbooker42
added
NoDocumentationNeeded
NoReleaseNotesNeeded
lbooker42
requested review from
devinrsmith,
nbauernfeind,
niloc132,
rcaudy,
chipkent and
jmao-denver
as code owners
devinrsmith
reviewed
Jun 21, 2023
|
I've claimed this is not a breaking change (old clients should be able to successfully talk to newer servers). @niloc132 should be able to theoretically confirm. That said, it might be nice to run a manual test. |
chipkent
requested changes
Jun 21, 2023
server/src/main/java/io/deephaven/server/table/ops/UpdateByGrpcImpl.java
Show resolved
Hide resolved
nbauernfeind
approved these changes
Jun 22, 2023
|
LGTM, too. |
rcaudy
approved these changes
Jun 22, 2023
chipkent
approved these changes
Jun 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the GRPC protobuf file to allow specification of duration strings for
update_byoperator time windows. This adds functionality while preserving the ability to provide durations in nanoseconds directly.Additional tests for the python client have been added.