Add UpdateBy Rolling operators to GRPC proto files and tests. #3623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbooker42
added
NoDocumentationNeeded
NoReleaseNotesNeeded
lbooker42
requested review from
chipkent,
jmao-denver and
rcaudy
as code owners
devinrsmith
reviewed
Mar 29, 2023
server/src/main/java/io/deephaven/server/table/ops/UpdateByGrpcImpl.java
Outdated
Show resolved
Hide resolved
java-client/session/src/test/java/io/deephaven/client/impl/UpdateBySpecBuilderTest.java
Show resolved
Hide resolved
table-api/src/main/java/io/deephaven/api/updateby/spec/RollingAvgSpec.java
Outdated
Show resolved
Hide resolved
table-api/src/main/java/io/deephaven/api/updateby/spec/RollingGroupSpec.java
Outdated
Show resolved
Hide resolved
table-api/src/main/java/io/deephaven/api/updateby/spec/RollingProductSpec.java
Outdated
Show resolved
Hide resolved
table-api/src/main/java/io/deephaven/api/updateby/spec/RollingSumSpec.java
Outdated
Show resolved
Hide resolved
chipkent
previously approved these changes
Apr 5, 2023
chipkent
previously approved these changes
Apr 19, 2023
rcaudy
reviewed
Apr 20, 2023
java-client/session/src/test/java/io/deephaven/client/impl/UpdateBySpecBuilderTest.java
Show resolved
Hide resolved
rcaudy
approved these changes
Apr 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3392