Fixes SubscribeToLogs example to work with authenticated channel #3400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
added
bug
nbauernfeind
reviewed
Feb 3, 2023
| @Override | ||
| public void onNext(LogSubscriptionData value) { | ||
| latch.countDown(); | ||
| ++count; |
There was a problem hiding this comment.
This is likely to be invoked from another thread. You need to make count, and error, volatile to avoid a racy test. (Or synchronize onNext / onError.)
There was a problem hiding this comment.
I think the semantics provided by the CountDownLatch are good enough - I can refactor a bit to get rid of count; and, onError / onComplete are guaranteed to only be called once, and visibility of error should be guarded by done. I'll re-push, let me know what you think.
nbauernfeind
approved these changes
Feb 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.