Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FetchPandasTable from gRPC Table API #3153

Closed
nbauernfeind opened this issue Dec 6, 2022 · 0 comments · Fixed by #3156
Closed

Remove FetchPandasTable from gRPC Table API #3153

nbauernfeind opened this issue Dec 6, 2022 · 0 comments · Fixed by #3156
Assignees
@niloc132 @nbauernfeind
Labels
feature request New feature or request grpc
Milestone
Backlog

Comments

@nbauernfeind
Copy link
Member

When working on authorization I noticed that FetchPandasTable is not implemented via the gRPC TableService API.

@niloc132 says that dataframes are fetched as widgets. These will go through the TicketResolverBase.AuthTransformation mechanism when fetched as an object.

It looks safe to drop this from the API.
@nbauernfeind nbauernfeind added feature request New feature or request grpc labels Dec 6, 2022
@nbauernfeind nbauernfeind added this to the Backlog milestone Dec 6, 2022
@nbauernfeind nbauernfeind self-assigned this Dec 6, 2022
@nbauernfeind nbauernfeind mentioned this issue Dec 6, 2022
Merged
@niloc132 niloc132 self-assigned this Dec 6, 2022
niloc132 added a commit to niloc132/deephaven-core that referenced this issue Dec 6, 2022
@niloc132
Remove unused gRPC method for DataFrames
6e9b801 
This has been superceeded by FetchObject and a plugin for Pandas.

Fixes deephaven#3153
@niloc132 niloc132 mentioned this issue Dec 6, 2022
Merged
nbauernfeind pushed a commit to niloc132/deephaven-core that referenced this issue Dec 8, 2022
@niloc132 @nbauernfeind
Remove unused gRPC method for DataFrames
d5fc8b3 
This has been superceeded by FetchObject and a plugin for Pandas.

Fixes deephaven#3153
niloc132 added a commit to niloc132/deephaven-core that referenced this issue Jan 13, 2023
@niloc132
Remove unused gRPC method for DataFrames
7e40b55 
This has been superceeded by FetchObject and a plugin for Pandas.

Fixes deephaven#3153
niloc132 added a commit that referenced this issue Jan 17, 2023
@niloc132
Remove unused gRPC method for Pandas DataFrames (#3156)
5da4064 
This has been superceeded by FetchObject and a plugin for Pandas.

Fixes #3153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niloc132 niloc132

@nbauernfeind nbauernfeind

Labels
feature request New feature or request grpc
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Remove unused gRPC method for Pandas DataFrames niloc132/deephaven-core
2 participants
@niloc132 @nbauernfeind