Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DE-7553: Smarten up the examples repo, organise things a bit #19

Merged
merged 5 commits into from
Sep 11, 2024
Merged

DE-7553: Smarten up the examples repo, organise things a bit #19

merged 5 commits into from
Sep 11, 2024

Conversation

rmoff
Copy link
Contributor

@rmoff rmoff commented Sep 10, 2024

No description provided.

hpgrahsl
hpgrahsl approved these changes Sep 10, 2024
View reviewed changes
Copy link

@hpgrahsl hpgrahsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

gunnarmorling
gunnarmorling approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@gunnarmorling gunnarmorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 1.5 suggestions inline.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@rmoff rmoff merged commit a7b3662 into main Sep 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunnarmorling gunnarmorling gunnarmorling approved these changes

@hpgrahsl hpgrahsl hpgrahsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmoff @gunnarmorling @hpgrahsl