Skip to content

Commit

Permalink
src: remove empty comment in node_http2.h
Browse files Browse the repository at this point in the history
This commit removes an "empty" comment in node_http2.h that I don't
think was intentional and as far as I can tell not a doxygen comment or
anything like that.

This was not picked up by the cpp linter so a suggestion has also been
added to the CheckComment function to detect these in the future.

PR-URL: nodejs#16400
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
  • Loading branch information
danbev committed Oct 25, 2017
1 parent 50d7275 commit 3e68e44
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion src/node_http2.h
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,6 @@ class Http2Options {

static const size_t kAllocBufferSize = 64 * 1024;

////
typedef uint32_t(*get_setting)(nghttp2_session* session,
nghttp2_settings_id id);

Expand Down
2 changes: 1 addition & 1 deletion tools/cpplint.py
Original file line number Diff line number Diff line change
Expand Up @@ -3021,7 +3021,7 @@ def CheckComment(line, filename, linenum, next_line_start, error):
# If the comment contains an alphanumeric character, there
# should be a space somewhere between it and the // unless
# it's a /// or //! Doxygen comment.
if (Match(r'//[^ ]*\w', comment) and
if (Match(r'(?://[^ ]*\w)|(?:////\s*$)', comment) and
not Match(r'(///|//\!)(\s+|$)', comment)):
error(filename, linenum, 'whitespace/comments', 4,
'Should have a space between // and comment')
Expand Down

0 comments on commit 3e68e44

Please sign in to comment.