Fix Tooltip when attaching to another mdl component #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `Options.on` instead of `Html.Events.on` to attach the event listener. This at least temporarily fixes the issue where hovering over an MDL component such as `Button` with a tooltip would cause the tooltip to stay visible. NOTE: This might have unintended consequences when using `Tooltip` with an MDL component with a ripple effect which also uses the `mouseleave` event.
thotypous
approved these changes
Mar 11, 2017
|
Anyone to merge this? |
|
I cherry-picked this in new-v8 (f2c6628). Thanks! Do you have a demo for the unintended side-effects with ripple? Otherwise, I will leave that potential problem to worry about later. :o |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Options.oninstead ofHtml.Events.onto attachthe event listener. This at least temporarily fixes the issue
where hovering over an MDL component such as
Buttonwith a tooltipwould cause the tooltip to stay visible.
NOTE: This might have unintended consequences when using
Tooltipwith an MDL component with a ripple effect which also uses the
mouseleaveevent.This at least temporarily resolves the
Click mecase from #240