Skip to content

Commit

Permalink
x86/kconfig: Select ARCH_WANT_FRAME_POINTERS again when UNWINDER_FRAM…
Browse files Browse the repository at this point in the history
…E_POINTER=y

It took me some time to understand the purpose of the tricky code at
the end of arch/x86/Kconfig.debug.

Without it, the following would be shown:

  WARNING: unmet direct dependencies detected for FRAME_POINTER

because

  81d3871 ("x86/kconfig: Consolidate unwinders into multiple choice selection")

removed 'select ARCH_WANT_FRAME_POINTERS'.

The correct and more straightforward approach should have been to move
it where 'select FRAME_POINTER' is located.

Several architectures properly handle the conditional selection of
ARCH_WANT_FRAME_POINTERS. For example, 'config UNWINDER_FRAME_POINTER'
in arch/arm/Kconfig.debug.

Fixes: 81d3871 ("x86/kconfig: Consolidate unwinders into multiple choice selection")
Signed-off-by: Masahiro Yamada <[email protected]>
Signed-off-by: Borislav Petkov (AMD) <[email protected]>
Acked-by: Josh Poimboeuf <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
  • Loading branch information
masahir0y authored and bp3tk0v committed May 20, 2024
1 parent 9dba9c6 commit 66ee363
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions arch/x86/Kconfig.debug
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ config UNWINDER_ORC

config UNWINDER_FRAME_POINTER
bool "Frame pointer unwinder"
select ARCH_WANT_FRAME_POINTERS
select FRAME_POINTER
help
This option enables the frame pointer unwinder for unwinding kernel
Expand All @@ -271,7 +272,3 @@ config UNWINDER_GUESS
overhead.

endchoice

config FRAME_POINTER
depends on !UNWINDER_ORC && !UNWINDER_GUESS
bool

0 comments on commit 66ee363

Please sign in to comment.