Launchd environment #261
Merged
Launchd environment #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds whitespace supression optionally, similar to the default behavior in Rails ActionView ERB templates. Just add - to a %> like so: -%> and it will remove trailing whitespace and newlines. This can also be done to the beginning tag for removing newlines from the beginning of the tag line.
Also suppresses the deprecation warning for the launchd exporter when using port instead of engine.port_for
launchd uses exec() under the hood when you specify ProgramArguments or Program so you must break apart program arguments into separate strings in an array or the command will fail
|
Thanks! This works much better. 😄 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an enhancement to the launchd exporter to also bring in environment variables defined and to ensure the program arguments are called correctly. Under the hood, launchd uses exec() which expects each string in the array to be a piece of the command arguments.
Another new piece of functionality is that you can now optionally use the trim_whitespace mode in your ERB templates by adding a - to the ERB tags.
Also, this is how I felt when the specs passed and I learned how launchd uses exec():
