Provide non blocking API #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnestler
force-pushed
the
provide-non-blocking-api
branch
from
b0b6342
to
87727af
Compare
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
+ Coverage 85.34% 86.47% +1.12%
==========================================
Files 3 3
Lines 116 133 +17
==========================================
+ Hits 99 115 +16
- Misses 17 18 +1
|
rnestler
force-pushed
the
provide-non-blocking-api
branch
from
87727af
to
5ad8764
Compare
That way the user can choose to just start a measurement and read the results later.
rnestler
force-pushed
the
provide-non-blocking-api
branch
from
5ad8764
to
7df48ff
Compare
dbrgn
reviewed
May 12, 2020
dbrgn
requested changes
May 12, 2020
Most of the time delays need to be used all over in the system, thus we can't just take ownership of it.
rnestler
force-pushed
the
provide-non-blocking-api
branch
from
757e35a
to
046e47a
Compare
dbrgn
requested changes
May 12, 2020
dbrgn
approved these changes
May 12, 2020
There was a problem hiding this comment.
Thanks! There are some more things that should be done before the next release:
- Provide an async wakeup function as well
- Add notes about async to README and to crate-level documentation
- Add an example that uses async calls (ideally an embedded one)
However all of them can be added in separate PRs, so let's merge this.
@rnestler can you squash the last two commits before merging?
That way the documentation is easier to read, since the async and blocking measurement functions are separate. Co-authored-by: Danilo Bargen <[email protected]>
rnestler
force-pushed
the
provide-non-blocking-api
branch
from
7691f2d
to
5c4bdd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.