Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgclirc: Clarify description of destructive_warning_restarts_connection option #1437

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

dbaty
Copy link
Member

@dbaty dbaty commented Nov 3, 2023

See discussion here: dbcli/pgcli.com#59 (review)

The same changes have been (or will soon be) applied on pgcli.com (see dbcli/pgcli.com#60).

@dbaty
Copy link
Member Author

dbaty commented Nov 3, 2023

@laixintao : as suggested by you here.

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04ca41a) 79.63% compared to head (02a32b8) 79.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1437   +/-   ##
=======================================
  Coverage   79.63%   79.63%           
=======================================
  Files          25       25           
  Lines        3035     3035           
=======================================
  Hits         2417     2417           
  Misses        618      618           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laixintao laixintao merged commit 5050f01 into main Nov 6, 2023
7 checks passed
@laixintao laixintao deleted the dbaty/destructive_warning branch November 6, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants