Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: alert for vue-showcase #718

Closed
wants to merge 3 commits into from
Closed

feat: alert for vue-showcase #718

wants to merge 3 commits into from

Conversation

annsch
Copy link
Collaborator

@annsch annsch commented Mar 23, 2023

  • examples and variants for DBAlert Component for Vue Showcase

@github-actions github-actions bot added the 📺showcases Changes to 1-n showcases label Mar 23, 2023
@github-actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/feat-add-missing-components-in-showcases

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/pull-request.yml:analyze/language:javascript. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

nmerget
nmerget reviewed Mar 24, 2023
View reviewed changes
showcases/vue-showcase/src/components/alert/Alert.vue
defaultComponentVariants[2].examples[3].code = `<DBAlert>Text</DBAlert>`;

// Behaviour
defaultComponentVariants[3].examples[0].code = `<DBAlert headline="Headline" :link=\"{href: "#"}\" onClick={()=>{alert("click close button")}}>Alert ${linkSlot}</DBAlert>`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you would use @click here right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, ofCourse.. copy & paste issue

@mfranzke
Copy link
Member

@annsch will we follow up with this approach or wait for Nicos suggested solution?

@annsch
Copy link
Collaborator Author

annsch commented Mar 24, 2023

@annsch will we follow up with this approach or wait for Nicos suggested solution?
@mfranzke I'd prefer the last

@mfranzke
Copy link
Member

I fear that this will change a lot again through #724

@mfranzke
Copy link
Member

mfranzke commented Apr 6, 2023

@annsch could you please adapt the latest changes by Nico to this PR?

@nmerget nmerget closed this Apr 14, 2023
@nmerget nmerget deleted the feat-add-missing-components-in-showcases branch April 14, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget left review comments

@mfranzke mfranzke Awaiting requested review from mfranzke mfranzke is a code owner

@dkolba dkolba Awaiting requested review from dkolba dkolba is a code owner

Assignees
No one assigned
Labels
📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annsch @mfranzke @nmerget