Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a11y form component ids #2599

Merged
merged 53 commits into from
Jul 10, 2024
Merged
Changes from 1 commit
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
5fcc7b0
fix: a11y issue for all form components
nmerget Apr 30, 2024
3514dd4
Merge branch 'main' of github.com:db-ui/mono into fix-a11y-form-compo…
nmerget Apr 30, 2024
51c14bf
fix: a11y issue for switch
nmerget Apr 30, 2024
dabcf94
fix: issue from PR
nmerget May 8, 2024
2b04630
Merge branch 'main' into fix-a11y-form-component-ids
nmerget May 8, 2024
28d00c9
fix: issue with vue
nmerget May 8, 2024
fa45de4
Merge remote-tracking branch 'origin/fix-a11y-form-component-ids' int…
nmerget May 8, 2024
55ddd0d
Merge branch 'main' into fix-a11y-form-component-ids
mfranzke May 10, 2024
91b2e60
Update packages/components/src/components/select/select.lite.tsx
nmerget May 10, 2024
ded12f9
Update checkbox.lite.tsx
mfranzke May 10, 2024
286eae3
Update input.lite.tsx
mfranzke May 10, 2024
524e892
Update textarea.lite.tsx
mfranzke May 10, 2024
4ad533c
Update input.lite.tsx
mfranzke May 10, 2024
613e971
fix: issues from PR
nmerget May 10, 2024
2f92ef4
Merge remote-tracking branch 'origin/fix-a11y-form-component-ids' int…
nmerget May 10, 2024
ad99509
Merge branch 'main' into fix-a11y-form-component-ids
nmerget May 10, 2024
99da69a
Merge branch 'main' into fix-a11y-form-component-ids
nmerget May 10, 2024
315e2e0
fix: issues with form-components
nmerget May 10, 2024
ea3abae
fix: removed unused dependency
nmerget May 10, 2024
3fd2d65
feat: add new tests for form-components for react- and vue-showcase
nmerget May 13, 2024
809fd76
Merge branch 'main' of github.com:db-ui/mono into fix-a11y-form-compo…
nmerget May 13, 2024
ce2d6a1
feat: add new tests for form-components for angular-showcase
nmerget May 13, 2024
54529cc
Merge branch 'main' into fix-a11y-form-component-ids
nmerget May 13, 2024
8749d59
Merge branch 'main' into fix-a11y-form-component-ids
nmerget May 13, 2024
70f4b76
fix: issue from PR
nmerget May 14, 2024
bb1987e
chore: update from main
nmerget May 14, 2024
309091f
Merge branch 'main' of github.com:db-ui/mono into fix-a11y-form-compo…
nmerget May 15, 2024
072bb2b
fix: issue with angular
nmerget May 15, 2024
a641c27
Merge branch 'main' into fix-a11y-form-component-ids
nmerget May 21, 2024
484ed3a
Merge branch 'main' into fix-a11y-form-component-ids
mfranzke May 30, 2024
dff6ca5
Merge branch 'main' of github.com:db-ui/mono into fix-a11y-form-compo…
nmerget Jun 26, 2024
09f1f23
chore: update from main
nmerget Jun 26, 2024
c823486
fix: issue with vue showcase
nmerget Jun 26, 2024
91f7074
Merge branch 'main' of github.com:db-ui/mono into fix-a11y-form-compo…
nmerget Jun 27, 2024
6abdad7
fix: issue with vue refs
nmerget Jun 27, 2024
5031097
chore: add comments for overwrites
nmerget Jul 5, 2024
9402d66
Merge branch 'main' into fix-a11y-form-component-ids
nmerget Jul 5, 2024
a7cc66f
fix: issues from PR
nmerget Jul 5, 2024
a4dcc9a
Merge branch 'main' into fix-a11y-form-component-ids
mfranzke Jul 8, 2024
754a576
Merge branch 'main' into fix-a11y-form-component-ids
mfranzke Jul 8, 2024
f6e6ab2
Merge branch 'main' into fix-a11y-form-component-ids
nmerget Jul 9, 2024
a3ba11c
Update packages/components/src/shared/constants.ts
nmerget Jul 9, 2024
e1ef8a0
Update showcases/angular-showcase/src/app/components/form/checkboxes/…
nmerget Jul 9, 2024
21dc640
Update showcases/angular-showcase/src/app/components/form/selects/sel…
nmerget Jul 9, 2024
280a468
Update showcases/angular-showcase/src/app/components/form/inputs/inpu…
nmerget Jul 9, 2024
051f70e
Update showcases/angular-showcase/src/app/components/form/textareas/t…
nmerget Jul 9, 2024
df1a288
Merge branch 'main' into fix-a11y-form-component-ids
mfranzke Jul 9, 2024
a72b6e2
Update showcases/angular-showcase/src/app/components/form/textareas/t…
nmerget Jul 10, 2024
3668211
Update showcases/angular-showcase/src/app/components/form/textareas/t…
nmerget Jul 10, 2024
6d18f0f
Update showcases/angular-showcase/src/app/components/form/textareas/t…
nmerget Jul 10, 2024
d6b3354
Update showcases/vue-showcase/src/components/form/Textareas.vue
nmerget Jul 10, 2024
71e30b7
chore: update from main
nmerget Jul 10, 2024
5d94ff2
Merge remote-tracking branch 'origin/fix-a11y-form-component-ids' int…
nmerget Jul 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update showcases/angular-showcase/src/app/components/form/inputs/inpu…
…ts.component.html

Co-authored-by: Maximilian Franzke <[email protected]>
  • Loading branch information
nmerget and mfranzke authored Jul 9, 2024
commit 280a4687a0f89a138c84f7550ffa45c623a887b3
Original file line number Diff line number Diff line change
Expand Up @@ -3,29 +3,32 @@
[model]="ngModel"
[control]="formControl.value"
>
<db-input
label="Plain"
placeholder="Placeholder"
message="Description"
icon="user"
name="input-name"
[value]="plain"
(change)="plain = $event.target.value"
/>
<db-input
label="ngModel"
placeholder="Placeholder"
message="Description"
icon="user"
name="input-name"
[(ngModel)]="ngModel"
/>
<db-input
label="formControl"
placeholder="Placeholder"
message="Description"
icon="user"
name="input-name"
[formControl]="formControl"
/>
<fieldset>
<legend>Different form approaches</legend>
<db-input
label="Plain"
placeholder="Placeholder"
message="Description"
icon="user"
name="input-name"
[value]="plain"
(change)="plain = $event.target.value"
/>
<db-input
label="ngModel"
placeholder="Placeholder"
message="Description"
icon="user"
name="input-name"
[(ngModel)]="ngModel"
/>
<db-input
label="formControl"
placeholder="Placeholder"
message="Description"
icon="user"
name="input-name"
[formControl]="formControl"
/>
</fieldset>
</app-form-wrapper>
Loading