Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: align playwright version via package.json #2539

Merged
merged 4 commits into from
Apr 17, 2024
Merged

chore: align playwright version via package.json #2539

merged 4 commits into from
Apr 17, 2024

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Apr 17, 2024

Proposed changes

We had issues with dependabot updating playwright.

By using only one reference (package.json) for every image we make sure to align the playwright version to all required files.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget enabled auto-merge (squash) April 17, 2024 11:13
@github-actions github-actions bot added 📕documentation Improvements or additions to documentation 🚢📀cicd Changes inside .github folder 📺showcases Changes to 1-n showcases labels Apr 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/chore-align-playwright-version

@mfranzke mfranzke changed the title chore: align playwright version via package.json chore: align playwright version via package.json Apr 17, 2024
@mfranzke mfranzke self-assigned this Apr 17, 2024
@mfranzke mfranzke mentioned this pull request Apr 17, 2024
Closed
@nmerget nmerget requested a review from mfranzke April 17, 2024 12:18
@nmerget nmerget merged commit dd5c8c5 into main Apr 17, 2024
28 checks passed
@nmerget nmerget deleted the chore-align-playwright-version branch April 17, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke approved these changes

@dkolba dkolba Awaiting requested review from dkolba dkolba is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees

@mfranzke mfranzke

Labels
🚢📀cicd Changes inside .github folder 📕documentation Improvements or additions to documentation 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
Open Beta Release - Leftovers (0.2.0)
Development

Successfully merging this pull request may close these issues.
2 participants
@nmerget @mfranzke