-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: CheckHealth doesn't work in neovim #765
fix: CheckHealth doesn't work in neovim #765
Conversation
CheckHealth calls display_debug_info(). However, error occured when loading jedi_vim.jedi.Script('')._evaluator.sys_path, because Evaluator.sys_path is unavailable variable.
If this broke, I'm sorry. It will break again once the virtualenv branch is merged. But then we'll probably have a public API to ask for this stuff. |
Oh I see. |
I think we should re-open and actually try to fix it, by handling the different variants (i.e. the current one, the one from this PR, and the one from the virtualenv branch). @narona |
Please don't try to work with the virtualenv branch, yet. It's work in progress and we can integrate it as soon as it's in good shape and the API is final. As for the rest, I agree that here in this pull request we should try to handle both those variants. |
Thanks for replies. |
No, I would suggest updating this PR to handle both the old and new "API". script_evaluator = jedi_vim.jedi.Script('')._evaluator
try:
sys_path = script_evaluator.project.sys_path:
except AttributeError:
sys_path = script_evaluator.sys_path |
ahh, I have misunderstood that new API will be added. |
Evaluator.project.sys_path is temporary fix, because Evaluator.sys_path is correct API. So, we handle the both the old and new API in preparation for merging virtualenv branch.
83655df
to
a606c94
Compare
Thanks! |
Hi. I found CheckHealth bug in neovim.
CheckHealth calls
display_debug_info()
.However, error occured when loading
jedi_vim.jedi.Script('')._evaluator.sys_path
,because
Evaluator.sys_path
is unavailable variable.