Cast integers with vim_eval #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
force-pushed
the
vim_eval-int
branch
2 times, most recently
from
7d7e70a
to
4ddbabd
Compare
This was referenced Apr 7, 2016
|
Why would people use |
This makes it clearer/more strict altogether and is future-proof in the sense that `vim.eval` might return integers for numbers in Vim after all. See davidhalter#553 for a very noisy discussion of what led to this. Although it might be a regression in neovim-python after all it is good to be on the safe side. The bonus here is that we get "notified" in case of a option that is expected to be an integer is a string instead. Fixes davidhalter#553.
Removed that from the commit message. |
|
Makes sense! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cast integers with vim_eval
This makes it clearer/more strict altogether and is future-proof in the
sense that
vim.evalmight return integers for ints in Vim after all.See #553 for a very noisy discussion of what led to this.
Although it might be a regression in neovim-python after all it is good
to be on the save side.
The bonus here is that we get "notified" in case of a option that is
expected to be a int is a string - although that might also cause some
weird issues in case someone uses "yes" instead of 1 (?!).
Fixes #553.