Skip to content

Commit

Permalink
SubmittingPatches: rebase to resolve conflicts
Browse files Browse the repository at this point in the history
pull request is not supposed to contain merge commits

Signed-off-by: Kefu Chai <[email protected]>
  • Loading branch information
tchaikov committed Jan 21, 2016
1 parent a2c1b53 commit 4d00a14
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions SubmittingPatches.rst
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,19 @@ feature.
to ping the reviewer again or comment on the pull request to ensure the updates
are noticed.

Sometimes your change could be based on an outdated parent commit and has
conflicts with the latest target branch, then you need to fetch the updates
from the remote branch, rebase your change onto it, and resolve the conflicts
before doing the force-push

.. code-block:: bash
$ git pull --rebase origin target-branch
So that the pull request does not contain any "merge" commit. Instead of "merging"
the target branch, we expect a linear history in a pull request where you
commit on top of the remote branch.

Q: Which branch should I target in my pull request?

A: The target branch depends on the nature of your change:
Expand Down

0 comments on commit 4d00a14

Please sign in to comment.