Ensure all error codes are correctly returned when using dbdctl #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Lapa <[email protected]>
|
Whoops. Good catch. At datto we use the library directly so I guess we never ran into this. Ill merge this first thing tomorrow morning (just to run the change by our QA). |
tcaputi
pushed a commit
that referenced
this pull request
Mar 7, 2016
Ensure all error codes are correctly returned when using dbdctl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After experimenting with dbdctl, I discovered that dbdctl can fail and still return 0. Whilst I could parse the string for error messages, it would defeat the purpose of having a return code at all.
Signed-off-by: Chris Lapa [email protected]