Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New-DbaDbTable - Drop table if creation fails and change DefaultEx to DefaultExpression #8150

Merged
merged 8 commits into from
Feb 7, 2022

Conversation

andreasjordan
Copy link
Contributor

Type of Change

  • Bug fix (non-breaking change, fixes # )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (effects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

@andreasjordan
Copy link
Contributor Author

Don't know why the unrelated test fails.

@potatoqualitee
Copy link
Member

Rerunning all incomplete

@potatoqualitee
Copy link
Member

oh hey andreas, tests for new-dbadbtable are disabled on Appveyor

# do not run on appveyor
    "appveyor_disabled" = @(

found that by looking for what could possibly be impacting that other command that's failing

@potatoqualitee
Copy link
Member

Seems it fails too often -- perhaps create a test on gh-actions.ps1

@potatoqualitee
Copy link
Member

you can also remove that test from pester.groups.ps1 to actually make it run, to see if tests actually pass

@andreasjordan
Copy link
Contributor Author

Thanks for the hint - now it works, tests pass.
Is there anything else that should be included in this PR? What about "DefaultString"?

@potatoqualitee
Copy link
Member

I like that too, if you wish

@potatoqualitee
Copy link
Member

this is awesome! I love it, thank you 🥳

@potatoqualitee potatoqualitee merged commit 71fc4d6 into development Feb 7, 2022
@potatoqualitee potatoqualitee deleted the NewDbaDbTable_fixes branch February 7, 2022 15:19
@drstonephd
Copy link

Wow, you folks are fast. I like the DefaultExpression and DefaultString. DBATools makes a DBAs life easier. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants