Tracing Service #53
Open
Tracing Service #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 11, 2013 15:53
ghost
assigned 
|
|
||
| } | ||
|
|
||
| struct App { | ||
| // See Ring::add below for the reason of this assertion | ||
| static_assert(!(MaxEntries & 1), "MaxEntries must be 2^M"); |
There was a problem hiding this comment.
That only check that the number is pair. To check for 2^M use this instead:
https://github.com/RAttab/lockless/blob/master/src/utils.h#L30
This checks that there's only one bit set which means that you're a power of 2 that's greater then 0
| } | ||
| } | ||
|
|
||
| private: | ||
| std::array<TraceEntry, MaxEntries> entries; | ||
| uint64_t index; | ||
| struct Ring { |
There was a problem hiding this comment.
Personal style comment which you're free to ignore: since you're in a cc file, you don't have to shove everything within a single class. I'd just shove them at file scope in an anonymous namespace which reduce the amount of crap you have in your class and makes everything easier to read and less indented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request includes two components :