PLAT-653: ensure "try" methods of fs utilities do not throw during commo... #127
Conversation
| // it doesn't exist | ||
| FsObjectInfo tryGetUriObjectInfo(const std::string & filename); | ||
| // it doesn't exist (deprecated, use getUriObjectInfo instead) | ||
| FsObjectInfo tryGetUriObjectInfo(const std::string & filename) __attribute__((__deprecated__)); |
There was a problem hiding this comment.
Why is this deprecated? I use it all over the place. It will stop lots of code from compiling.
There was a problem hiding this comment.
I thought this would only generate a warning. The deprecation, because both methods are now using the same code, and my intention was for it to serve only as an indicator for new code.
There was a problem hiding this comment.
@jeremybarnes does getUriObjectInfo need to throw if the object is not found? Is it considered part of the semantics?
There was a problem hiding this comment.
yes, it is an important part of the semantics. It allows you to chain calls without regard for checking the return code for each one.
|
@jeremybarnes updated with latest code from master, can you rereview? |
Conflicts: service/s3.cc
...n failures