Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ignore #467

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

update ignore #467

wants to merge 4 commits into from

Conversation

wustmz
Copy link

@wustmz wustmz commented Aug 15, 2022

No description provided.

@dataabc
Copy link
Owner

dataabc commented Aug 15, 2022

感谢热心贡献代码。第一个commit是可以的,关于第二个,我有一些建议:
1.新代码注释了一些初始化的代码,我不知道原因,如果确实不需要,可以去掉;
2.新代码增加了与邮件的交互,但是配置是在代码中,我认为在config文件中会更好;
3.代码中貌似有你的私人邮件和密钥,这是比较私密的东西,可能会给你的账号带来安全问题,为了邮件的安全,建议删除,可以使用[email protected]之类的替代。

这个只是我个人的理解,可能有不对的地方,再次感谢。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants