-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apple aarch64 support #544
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #544 +/- ##
==========================================
- Coverage 94.22% 94.19% -0.03%
==========================================
Files 16 16
Lines 797 793 -4
==========================================
- Hits 751 747 -4
Misses 46 46 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That doesn't seem too stressful. Decent performance?
I wonder if the fast path is still faster on a modern x64 chip with a recent compiler.
I get
on an |
That is faster than my i7-6700K CPU @ 4.00GHz, so I'd say it compares favorably! My benchmark results(anonlink) [brian@hardbyte-nzxt anonlink]$ python -m anonlink.benchmark Anonlink benchmark -- see README for explanation ------------------------------------------------ using 'greedy_solve_native' as solver and 'dice_coefficient_accelerated' as similarity metric |
for now, just doing the slow path in dice. Don't really feel like reading assembly instruction manuals...