Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring project up to date #64

Merged
merged 12 commits into from
Jan 25, 2024
Merged

Conversation

jacobtomlinson
Copy link
Contributor

Trying to bring the project up to date so that development can continue:

  • Removed the experimental TUI as it used a very old textual version and lots of things were breaking. This can be reinstated later.
  • Bumped Python versions.

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.14%. Comparing base (d608979) to head (fce21f1).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
dask_ctl/discovery.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #64       +/-   ##
===========================================
+ Coverage   49.87%   71.14%   +21.27%     
===========================================
  Files          30       10       -20     
  Lines        1175      357      -818     
===========================================
- Hits          586      254      -332     
+ Misses        589      103      -486     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobtomlinson jacobtomlinson merged commit afc0e5c into dask-contrib:main Jan 25, 2024
12 checks passed
@jacobtomlinson jacobtomlinson deleted the update branch January 25, 2024 13:33
@davidbrochart
Copy link

@jacobtomlinson I was wondering what was the status of the Textual-based TUI? I see it was removed in this PR, but do you plan to bring it back with the latest Textual?
I'd like to make a jpterm plugin for it, something similar to the JupyterLab Dask extension. Do you think I could steal the code you removed here, and try to adapt it to the latest Textual?

@jacobtomlinson
Copy link
Contributor Author

jacobtomlinson commented Feb 27, 2024

@davidbrochart I would love to bring the TUI back, but it is firmly in the category of "side project I would love to work on but don't have time for".

A plugin for jpterm would be amazing. I wonder if we could design things in a way that would allow Dask widgets to be used in both projects one day. I never finished things here, but if you want to grab what I did and adapt it then please go ahead.

Keep me in the loop and I'll see if I can find time to help out!

@davidbrochart
Copy link

@davidbrochart I would love to bring the TUI back, but it is firmly in the category of "side project I would love to work on but don't have time for".

I understand, jpterm is actually exactly that kind of project for me :)

A plugin for jpterm would be amazing. I wonder if we could design things in a way that would allow Dask widgets to be used in both projects one day. I never finished things here, but if you want to grab what I did and adapt it then please go ahead.

That would be a great long-term goal, but starting from what you had here might be more approachable for me. I'll definitely let you know if/when I get something working. BTW, I remember you posted some pretty impressive screencasts demoing this TUI, but I cannot find it anymore. I think it was on Twitter, do you have a link to a post by any chance?

@jacobtomlinson
Copy link
Contributor Author

jacobtomlinson commented Feb 29, 2024

Yeah totally understand.

Maybe this one? https://twitter.com/_JacobTomlinson/status/1559442768983998465

@davidbrochart
Copy link

Yes, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants