Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing internal types for transaction and block #286

Merged
merged 2 commits into from
Jun 7, 2023
Merged

fix: missing internal types for transaction and block #286

merged 2 commits into from
Jun 7, 2023

Conversation

markin-io
Copy link

@markin-io markin-io commented Jun 7, 2023 •
edited
Loading

Issue being fixed or feature implemented

Fix adds missing declarations for the internal types of Block and Transaction, and also fixes a few inconsistencies in the Transaciton type itself

What was done?

How Has This Been Tested?

  • SDK build and types test
  • Wallet lib types test

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

@markin-io markin-io changed the title fix: Transaction types fix: missing internal types Jun 7, 2023
@markin-io markin-io changed the title fix: missing internal types fix: missing internal types for transaction and block Jun 7, 2023
shumkov
shumkov approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@markin-io markin-io merged commit 8675029 into master Jun 7, 2023
@Mhmonicox Mhmonicox mentioned this pull request May 25, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Jul 17, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Jul 30, 2024
Open
This was referenced Aug 10, 2024
Open
Open
@Mhmonicox Mhmonicox mentioned this pull request Aug 28, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Sep 7, 2024
Open
This was referenced Sep 14, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@shuplenkov shuplenkov shuplenkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markin-io @shumkov @shuplenkov