Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: bls lib usage #212

Merged
merged 3 commits into from
Dec 25, 2020
Merged

refactor: bls lib usage #212

merged 3 commits into from
Dec 25, 2020

Conversation

antouhou
Copy link
Collaborator

Issue being fixed or feature implemented

Memory leaks when using dashcore-lib and using crypto/bls

What was done?

Refactor crypto/bls:

  • Add new .verifyAggregatedSignature method
  • Now BLS compilation happens only once and not once per each crypto/bls import

How Has This Been Tested?

Run the tests

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

@antouhou antouhou changed the base branch from master to v0.19-dev December 25, 2020 12:22
jawid-h
jawid-h approved these changes Dec 25, 2020
View reviewed changes
Copy link
Collaborator

@jawid-h jawid-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

shumkov
shumkov approved these changes Dec 25, 2020
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

@antouhou antouhou merged commit 942368c into v0.19-dev Dec 25, 2020
@antouhou antouhou deleted the refactor-bls-lib-usage branch December 25, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@jawid-h jawid-h jawid-h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antouhou @shumkov @jawid-h