Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed deprecated simple transaction from logics & docs #177

Merged
merged 2 commits into from
Sep 30, 2020

Conversation

Alex-Werner
Copy link

Issue being fixed or feature implemented

In 0.13, simpleTransaction were introduced as a initial improvement over InstantSend (was limited to 4 inputs), now this limitation has been removed and simpleTransaction are gone.
This PR updates implementation and documentation.

What was done?

  • docs: removed .isSimpleTransaction from typings
  • fix: removed .isSimpleTransaction from Transaction
  • docs: removed simple transaction documentation
  • tests: removed isSimpleTransaction tests

How Has This Been Tested?

Using current test suite minus removed unit test.

Breaking Changes

  • fix(Transaction): .isSimpleTransaction is removed

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

Copy link

@thephez thephez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concept ACK

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Alex-Werner Alex-Werner merged commit 5b4afea into v0.19-dev Sep 30, 2020
@Alex-Werner Alex-Werner deleted the fix/deprecated-simple-tx branch September 30, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants