Remove trans template tag from output of admin filter choice #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darklow
added a commit
that referenced
this pull request
Oct 25, 2013
Remove trans template tag from output of admin filter choice
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The django contrib admin uses:
{% blocktrans with filter_title=title %} By {{ filter_title }} {% endblocktrans %}whereas django-suit uses:
{% trans title|capfirst %}It seems to me that an attempt to translate the title is only attempted in the django-suit case. The django contrib admin just translates the context "By [...]" but not the filter title itself.
The current state of the django-suit template results in a DjangoUnicodeDecodeError when the filter title contains letters like "å", "ä" and "ö" (I'm not completely certain why this is).