Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use webViewMediaPlaybackAlwaysAllow to control autoplay on web too. #468

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

bamnet
Copy link
Contributor

@bamnet bamnet commented Mar 11, 2021

We can enable autoplay on <iframe> elements on the web by setting the allow="autoplay" attribute. This allows YouTube videos to play automatically.

@daohoangson
Copy link
Owner

Thank you for the PR, I think it looks great! Let's wait for #469 then rebase your branch in order to fix the checks.

@daohoangson
Copy link
Owner

master is ready, please rebase your branch for the mocktail fix. Thank you very much @bamnet

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #468 (18917f6) into master (2483136) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #468   +/-   ##
=======================================
  Coverage   96.78%   96.78%           
=======================================
  Files          45       45           
  Lines        2798     2798           
=======================================
  Hits         2708     2708           
  Misses         90       90           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2483136...18917f6. Read the comment docs.

@bamnet
Copy link
Contributor Author

bamnet commented Mar 12, 2021

Done!

@daohoangson daohoangson merged commit e0236d8 into daohoangson:master Mar 12, 2021
@daohoangson
Copy link
Owner

Checks are all green. I merged it 🚀

Once again, thank you @bamnet

daohoangson added a commit that referenced this pull request Mar 12, 2021
@daohoangson
Copy link
Owner

I have released version 0.6.0-rc.2021031201 with this change, you may need to run flutter pub upgrade to get it in your app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants