Fix HiDPI over-scrolling issue #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hulkholden mind taking a look at this? |
|
There were no comments, so I'm merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you visit https://rawgit.com/danvk/dygraphs/master/tests/demo.html on a "retina" device and shrink the window to match the width of the chart, you'll find that there's a mysterious horizontal scroll bar.
This was due to dygraph-canvas.js mysteriously re-setting the width of g.graphDiv. It's not clear why it would do this, since it's already been set in Dygraph.prototype.resizeElements_. It's also unclear why it would set the width and not the height. I'm guessing this is a relic -- the tests pass with the line removed.