Kill code #280
Merged
Kill code #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| a.href = url; | ||
| return li; | ||
| } | ||
| if (this.tc == null) { | ||
| description.innerHTML = 'Test cases:'; | ||
| description.textContent = 'Test cases:'; |
There was a problem hiding this comment.
Wow thanks for catching all these. No reply required.
|
I don't have to do another pass unless you ask. Removing those third-party packages is a good effort. |
|
Addressed all comments & merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should look familiar -- it's a simplified version of my old "shrink" pull request (#263).
This pull request does the following:
This shrinks the minified code size from 141427 --> 126509 bytes (10%). It will also simplify some later closure changes.
What this doesn't include from the older pull request is the mass removal of exported symbols. That's better handled by an "exports" file in closure-land.