LogScale and customBars with negative values #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When LogScale and customBars are enabled, it was verifying if the value was negative by using a <= on an array and then inserting a null. This caused exceptions in rollingAverage(), the value can't be null when using customBars. (This a new patch based on the current code, since pull request #236 was getting old).
| @@ -2821,12 +2821,20 @@ Dygraph.prototype.extractSeries_ = function(rawData, i, logScale) { | |||
| if (logScale) { | |||
| // On the log scale, points less than zero do not exist. | |||
| // This will create a gap in the chart. | |||
| if (point <= 0) { | |||
| if (errorBars || customBars) { | |||
| for (var k = 0; k < point.length; k++) { | |||
There was a problem hiding this comment.
Add a comment here:
// point.length is either 2 (errorBars) or 3 (customBars)
I was initially confused because I read this as a loop over all the points, rather than the elements of a single point.
|
For some reason I can't leave comments within the code. Please just put the else on the same line as the closing brace. e.g. if (cond) { should be if (cond) { |
|
Alright, this looks acceptable and is small enough that Klaus and I should be able to make this work. Thanks, @wimme and sorry for the delay. |
kberg
added a commit
that referenced
this pull request
Jun 6, 2013
LogScale and customBars with negative values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When LogScale and customBars are enabled, it was verifying if the value was negative by using a <= on an array and then inserting a null. This caused exceptions in rollingAverage(), the value can't be null when using customBars.
(This a new patch based on the current code, since pull request #236 was getting old).